Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer: Fix certain Swiftgen installations #794

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

SwiftCoderJoe
Copy link
Contributor

When running scripts from an Apple Silicon Mac, the $PATH is different from your user's $PATH (see this discussion). Since contributing.md suggests you install Swiftgen using Homebrew, we should definitely be supporting this use case as well as we possibly can.

Furthermore, a cryptic Command PhaseScriptExecution failed with a nonzero exit code appears when Swiftgen is not found, so I added a new error instructing developers to go to contributing.md for installation instructions.

@ericswpark
Copy link
Contributor

Can confirm that this PR fixes the build failing on ASi due to Swiftgen.

@LePips
Copy link
Member

LePips commented Jun 23, 2023

Thank you! I still have my old Homebrew installation before they migrated installation destinations so it's always worked for me.

@LePips LePips merged commit adde7b2 into jellyfin:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants