Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and ItemView.AboutView Cards #788

Merged
merged 8 commits into from
Jun 13, 2023
Merged

Cleanup and ItemView.AboutView Cards #788

merged 8 commits into from
Jun 13, 2023

Conversation

LePips
Copy link
Member

@LePips LePips commented Jun 8, 2023 •
edited
Loading

  • Organizes base resource files (assets, entitlements, .plist) into Resources
  • Moves stuff from Shared/Views to Shared/Components
    • these are components and not full screen views
    • along with other view organization
  • Refactors ItemView.AboutView
    • cards are now split into separate components
    • RatingsCard that shows the Rotten Tomatoes and community score
      • this will become Ratings and Links on iOS which will include the external links (IMDB, TMDB, etc.)
      • currently does not push a new view like the other cards
  • More minor localization
  • Refactors custom button onSelect
  • Starts some work on refactoring the ServerListView. That screen and UserListView will be redone
  • Refactors TruncatedText
  • Adds tag to tvOS item descriptions

@LePips LePips marked this pull request as ready for review June 9, 2023 23:17
PangMo5
PangMo5 previously approved these changes Jun 10, 2023
View reviewed changes
@LePips LePips requested a review from PangMo5 June 13, 2023 03:46
@LePips LePips merged commit ddbe77e into jellyfin:main Jun 13, 2023
@LePips LePips deleted the cleanup-and-item-about-cards branch June 13, 2023 04:25
@LePips LePips added the enhancement New feature or request label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PangMo5 PangMo5 PangMo5 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LePips @PangMo5