Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log decoding errors #630

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Log decoding errors #630

merged 1 commit into from
Dec 8, 2022

Conversation

kcramer
Copy link
Contributor

@kcramer kcramer commented Nov 21, 2022

While debugging issue #621 I noticed the app does not log JSON decoding errors. They are logged with an error code of 200 and description of "Unknown Error".

This patch logs the errors as a decoding error and includes the associated data to help debug such issues. Perhaps it might also help to assign an error code (maybe -3) for such errors?

@LePips
Copy link
Member

LePips commented Dec 8, 2022

Apologies that I haven't gotten to this. I am rewriting the entire ViewModel layer which this is a part of (#530, which is now #593), but I won't trouble you with that and just accept this as a note while I work on better error handling.

@LePips LePips merged commit a0c1aae into jellyfin:main Dec 8, 2022
@kcramer
Copy link
Contributor Author

kcramer commented Dec 10, 2022

Thanks for the update. If there is something I can do to help, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants