Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds "use fmp4" experimental option #623

Merged
merged 1 commit into from
Nov 3, 2022
Merged

Conversation

sul4bh
Copy link
Contributor

@sul4bh sul4bh commented Nov 1, 2022

Fixes issue #610

Adds a new experimental option that makes the native player use fmp4 segment container instead of ts. HEVC/HDR is only supported in fmp4 stream as documented here: "The container format for HEVC video MUST be fMP4.", https://developer.apple.com/documentation/http_live_streaming/http_live_streaming_hls_authoring_specification_for_apple_devices

FYI, fmp4 setting is already available in the web client:
Screenshot 2022-11-01 at 10 12 26 AM

The new experimental option
IMG_0046

HDR now works as expected on my Apple TV
IMG_0045

@sul4bh
Copy link
Contributor Author

sul4bh commented Nov 2, 2022

Not sure why tests did not run for this PR.

@LePips
Copy link
Member

LePips commented Nov 3, 2022

That's just due to #562, which is fine. Carthage is broken right now and should anticipate a fix soon.

I'm glad that the change is small to get HDR with the native player. Since it's so small and technically a proven "feature-that-works" I'll most likely make it an option in my current work and it won't remain in experimental, also because I've refactored the view model that is used but I won't bother you with worrying about that.

@LePips LePips merged commit 06044e8 into jellyfin:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants