Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for folder-type library items #351

Merged
merged 5 commits into from
Jan 28, 2022

Conversation

mshockwave
Copy link
Contributor

  • Add a new BaseItemDto.ItemType member: .folder.
  • Use CollectionItemViewModel to display folder-type item.
  • For each episode in a folder, fallback to primary image if series
    primary image is not available.
  • (tvOS) fixed a bug in LibraryListView where proper parent ID was not passed
    to LibraryViewModel.

This PR also lifts some restricts that prevent non- movies or tvshows type libraries from being displayed.

  - Add a new BaseItemDto.ItemType member: .folder.
  - Use CollectionItemViewModel to display folder-type item.
  - For each episode in a folder, fallback to primary image if series
    primary image is not available.
And fixed a bug in LibraryListView where proper parent ID was not passed
to LibraryViewModel.
@LePips
Copy link
Member

LePips commented Jan 26, 2022

Thanks for your contribution! I left a couple comments.

And restore the filter that only shows supported library types.
By default, a library shows its items in a flatten view. This patch
further adds an option that allows users to show items grouped in their
own folders as well.
@LePips LePips self-requested a review January 28, 2022 06:12
@LePips LePips added the enhancement New feature or request label Jan 28, 2022
@LePips LePips merged commit 6bd0781 into jellyfin:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants