Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] [tvOS] Sign-In Flow - User Auto Time-Out #1447

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chickdan
Copy link
Contributor

@chickdan chickdan commented Mar 5, 2025

Early efforts in implementing https://github.com/ViacomInc/TVOSPicker mentioned in #1419

I think it's getting close but I found a bug with the .blurredFullScreenCover(isPresented:) view modifier. In both SignOutIntervalSection and VideoPlayerSettingsView the presented blurred overlay immediately dismisses itself with the following error:

Attempt to present <_TtGC7SwiftUI29PresentationHostingControllerVS_7AnyView_: 0x108071000> on <_TtGC7SwiftUI29PresentationHostingControllerVS_7AnyView_: 0x107875800> (from <_TtGC7SwiftUI19UIHostingControllerVVS_P10$1afce442c21BridgedNavigationView8RootView_: 0x1078e5000>) while a presentation is in progress.

@JPKribs
Copy link
Member

JPKribs commented Mar 5, 2025

In one of the other PR that I have open, I wanted to do something similar to the blurred full screen and was running into a similar error. So, I ended up adding the view to the coordinator and calling it with .fullScreen instead of .push or .modal.

I was basing it off of the item overview, which does this same thing:

https://github.com/jellyfin/Swiftfin/blob/main/Swiftfin%20tvOS/Views/ItemOverviewView.swift


I ended up doing it at the same way for both my open playlist and filters PR. It's kind of a pain and adds an extra step, but it should work for getting you past that issue! I did it here with the filter:

https://github.com/JPKribs/Swiftfin/blob/tvOSLetterPicker/Shared/Coordinators/LibraryCoordinator.swift

@JPKribs JPKribs added the enhancement New feature or request label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants