[tvOS] Fix ItemType Libraries #1423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This only really applies to tvOS.
LePips
requested changes
Feb 7, 2025
There was a problem hiding this comment.
Good catch. I think to more closely match the logic prior to #1411, we should instead set parameters.isRecursive = true by default and in the default implementation of setParentParameters the parameters.isRecursive = true can be removed from there.
These changes should now be in the latest commit. I've tested and the libraries still appear to be correct for both |
LePips
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #1411 we drop the
isRecursiveflag. This is only a requirement foritemTypelibraries. I've added it to the bool logic so if thefilter.itemType.isNotEmptythen make it recursive. Resolves the issue where these libraries are folders instead of the items. See screenshot.Screenshot
Fixes:
