[tvOS] Login Flow Cleanup - Second Pass

[JPKribs]

Login Flow UI Updates

Initial Login Screen

Connect to Server - Remove Duplicate Icons

New Version:

Previous Version:

Server Management

Server Bar - Ensure Menus are same sizing

New Version:

Previous Version:

Server Configuration

Edit Server View - Clean up menu buttons

Additional UI Elements

User Sign-In - Add Background Image for Server

---

Outstanding Issue

tvOS User Sign-In Crash

This could be an emulator issue but I see this issue where the first time I login with a new user, Swiftfin crashes. Restarting, the user still exists but it's not great to restart after each login.

[LePips]

As I was typing a comment for this change I thought instead to just implement the same Menu/Button conditioning for server selection when it is all.

Using the user selection a bit more, I think we may want to move the Add User button from an inline item with the users and instead have it be a button on the left/leading side of the server selection to make the stack symmetrical. Maybe also for iOS to move it to the top trailing menu. We can take a look at that later.

[JPKribs]

Using the user selection a bit more, I think we may want to move the Add User button from an inline item with the users and instead have it be a button on the left/leading side of the server selection to make the stack symmetrical. Maybe also for iOS to move it to the top trailing menu. We can take a look at that later.

I can do that! One item of note, on user sign in on tvOS, disabled buttons square off. IMO, it's a little wonky looking but not an issue per-say. Wanted to run it by you while I was touching up login flow:

I believe I have this resolved with the rounding:

ListRowButtons should now better reflect iOS as well.

[JPKribs]

Okay! Take 2. I've made some additional changes.

• I updated the ListRowButton to have a .destructive that mirrors iOS.
• I updated the ListRowButton to retain its rounded corners even when disabled.
• Delete button now uses the same ListRowButton .destructive to mirror.

Delete User Buttons

Selected User - Non-Focused Delete:

Selected User - Focused Delete:

Disabled Delete:

Server Details Page Buttons

Old Buttons were cards inside of forms... I actually did this a while ago so that's on me:

The new buttons fill this out appropriately:

[LePips]

Let's leave out the add user button changes as that change would also consist of more cleanup within SelectUserView.

[JPKribs]

Let's leave out the add user button changes as that change would also consist of more cleanup within SelectUserView.

Sounds good. Those changes should now be reverted!

Edit: Added a label while I am in these files. Also, updated the screenshots for this PR to reflect it's current version.

[LePips]

Looks great!