Implement General Errors #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acvigue
approved these changes
Aug 12, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Implements general error handling from network calls from within view models.
Why
There currently was none, as errors were handled on a case-by-case basis in some places.
Comments
This implementation is temporary as the error parsing (URL, HTTP URL, and API) calls should be handled within the JellyfinAPI at the network layer. I will work on that in the future and this work is only for us to surface errors in development. The work is repetitive and messy which I am not happy about and again, this is very very temporary. I will create all of the specific and necessary issues with the work.
While working on this, I also came across many problems with the packages that we use and how they have conflicting and redundant types (Puppy.LogLevel and JellyfinAPI.LogLevel for example). We need to clean up the dependencies so that we don't face this anymore.