Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Player Comparison Page #1302

Merged
merged 24 commits into from
Nov 4, 2024
Merged

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Nov 2, 2024

Summary

Since there is a strange mix between AVKit and VLCKit features, I thought it would be nice to document the differences between the two of these. I was motivated by this discussion and expanded on it by mirroring supported codecs directly from the device profile code that was written.

The goal for this PR is to have a reference to point to for questions about the differences between players.

New Players Page

@RC2225
Copy link

RC2225 commented Nov 2, 2024

Maybe add to the VLCKit audio section that audio over airplay has around 2 second delay while nativ is fine. See #420

@Citrus0299
Copy link

Citrus0299 commented Nov 3, 2024

This is a great addition, what about the TRUE HD, TRUE HD Atmos and EAC3 Atmos audio codecs?
It should also be noted that just because the player does support the codec, the hardware might not be able to pass it through, and it will be converted on device instead.

If for example there would be no possibility to direct play DV video with TRUE HD Atmos even though the Apple TV will do a lossless conversion to LPCM without the spatial metadata, there would be no point to download the app for me.

Update to include codecs that are not supported by either video player.
Copy link
Contributor

@holow29 holow29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Added a couple of comments, but I think it looks good otherwise.

@JPKribs
Copy link
Member Author

JPKribs commented Nov 3, 2024

Thanks for working on this. Added a couple of comments, but I think it looks good otherwise.

Thank you for giving this a second look over! To be frank, I don't really encode HDR or anything too fancy so most of what I have is coming from your initial work on #519, and our finalized Device Profiles we have in code now. Additionally, there are some items in there from VLCKit / AVKit documentation but I'm not going to be the best expert for this.

I'm not at my desktop so I can't update the screenshot but my current version can be found here:

https://github.com/JPKribs/Swiftfin/blob/playerDocumentation/players.md

Let me know if there are any additional revisions!

@Citrus0299
Copy link

Citrus0299 commented Nov 3, 2024

Thanks a lot. I just noticed that DTS-HD MA is also missing from the list.

I don't really encode HDR or anything too fancy

That's interesting as I only keep the highest quality possible in it's native format.

@holow29
Copy link
Contributor

holow29 commented Nov 3, 2024

Made a couple more comments on HDR section, but otherwise looking good!

@JPKribs
Copy link
Member Author

JPKribs commented Nov 3, 2024

Made a couple more comments on HDR section, but otherwise looking good!

I had one last question on HDR, but then I feel ready to go with this. I appreciate your help looking this over!

Requires AV1 for Dolby Vision 10
AV1 disclaimer
Finally done!
@JPKribs JPKribs requested a review from LePips November 4, 2024 22:07
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this and I'm glad that others were able to contribute!

I Copilot just condensed the tables and I mostly made grammatical changes, as well as moving into Documentation since I feel like we may have more in the future.

@LePips LePips merged commit 83843e2 into jellyfin:main Nov 4, 2024
4 checks passed
@JPKribs JPKribs deleted the playerDocumentation branch November 5, 2024 05:09
@JPKribs JPKribs added the documentation Improvements or additions to documentation label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants