-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Meta] Player Comparison Page #1302
Conversation
final version
Actual last one
Add player section
Make note that transcoding exists.
Maybe add to the VLCKit audio section that audio over airplay has around 2 second delay while nativ is fine. See #420 |
This is a great addition, what about the TRUE HD, TRUE HD Atmos and EAC3 Atmos audio codecs? If for example there would be no possibility to direct play DV video with TRUE HD Atmos even though the Apple TV will do a lossless conversion to LPCM without the spatial metadata, there would be no point to download the app for me. |
Update to include codecs that are not supported by either video player.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Added a couple of comments, but I think it looks good otherwise.
HDR Section & Notes
HDR disclaimers
Thank you for giving this a second look over! To be frank, I don't really encode HDR or anything too fancy so most of what I have is coming from your initial work on #519, and our finalized Device Profiles we have in code now. Additionally, there are some items in there from VLCKit / AVKit documentation but I'm not going to be the best expert for this. I'm not at my desktop so I can't update the screenshot but my current version can be found here: https://github.com/JPKribs/Swiftfin/blob/playerDocumentation/players.md Let me know if there are any additional revisions! |
Thanks a lot. I just noticed that DTS-HD MA is also missing from the list.
That's interesting as I only keep the highest quality possible in it's native format. |
Made a couple more comments on HDR section, but otherwise looking good! |
I had one last question on HDR, but then I feel ready to go with this. I appreciate your help looking this over! |
Requires AV1 for Dolby Vision 10
AV1 disclaimer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this and I'm glad that others were able to contribute!
I Copilot just condensed the tables and I mostly made grammatical changes, as well as moving into Documentation
since I feel like we may have more in the future.
Summary
Since there is a strange mix between AVKit and VLCKit features, I thought it would be nice to document the differences between the two of these. I was motivated by this discussion and expanded on it by mirroring supported codecs directly from the device profile code that was written.
The goal for this PR is to have a reference to point to for questions about the differences between players.
New Players Page