[iOS & tvOS] Add 'Enable Rewatching' and ' Max days' to Next Up

[JPKribs]

Context

Resolves: #1211

This is a rework #1212 where I DIDN'T try to rebase on Main, resulting in a git nightmare.

Summary

This PR enables a feature found on Jellyfin-Web that limits the number of items in the 'Next Up' section. To further mirror Jellyfin-Web, this feature uses 0 as disabled (All items are shown in Next Up) and only includes the parameter for NextUpDateCutoff when this is greater than 0.

While I was in there, realized that Jellyfin-Web had an option for EnableRewatching so included that in this PR. I was basing my Parameters off of this section of Jellyfin-Web: https://github.com/jellyfin/jellyfin-web/blob/master/src/components/homesections/sections/nextUp.ts

Screenshots

iOS

New Settings (Disabled)

New Settings (1 Day)

New Settings (Multiple Days)

tvOS

New Settings (Location)

New Settings (Disabled)

New Settings (1 Day)

New Settings (Multiple Days)

New Settings (Subtitle Update)

[JPKribs]

This is up to date, merge-able on Main now, and cleaned up with only the new PR items.

I have a single outstanding issue:

This works, but the Ok/Done button is always the number??? I don't set that anywhere and I've been screwing around with this trying to fix it to no avail. I'm going to try this again with some fresh eyes later in the week. Unless @LePips, are you aware of what is going on here? It's only impacting tvOS.

Other than the tvOS Alert Button, I think all other changes are ready.

[LePips]

Per the tvOS issue of dismissal in #1212 (comment), that happens in the simulator for me when I use return on the keyboard and works as expected when I use the on-screen remote.

Per the additional button on tvOS with the alert, that looks like a SwiftUI bug and probably nothing we can do about it.

[JPKribs]

I've updated this with the last outstanding changes from the review. There is a TODO for the weird tvOS Alert Button bug(?) and I've merge in missing changes on Main. Let me know if there is anything else needed! Otherwise, I think this is ready.

[sjorge]

I'm not a developer so this is probably a dumb question, but why not use a simple text field that only accepts numbers for this?

That should work on iOS and tvOS, there is even a simple number one I think? (Although that might be 18.x only, I've only recently seen that for the first time)

[JPKribs]

That should work on iOS and tvOS, there is even a simple number one I think? (Although that might be 18.x only, I've only recently seen that for the first time)

I might be mistaken but this IS using the default TextField:

TextField(
    L10n.nextUpDays,
    value: $maxNextUp,
    format: .dayInterval(range: 0 ... 1000)
)
.keyboardType(.numberPad)

The primary item we are discussing is the delivery method for this. The popup is an 'alert' which is working fine on both iOS and tvOS but for whatever reason, the ok button that all alerts just have by default is showing the wrong text on tvOS. The alert presents the TextField where edits are made without taking the user to a new screen or covering up the existing screen (see below). This is either something not working correctly with the tvOS emulator for XCode or SwiftUI itself.

iOS:

Since we're a ways away from a tvOS build on TestFlight (NOT a statement just my assumption), I'd argue this is worth revisiting at a later point instead of engineering 2 separate solutions to account for functionality that should just work in SwiftUI.

I intend on keeping an eye on this and, as a build is available for tvOS, I can confirm if this issue is present on a non-emulator and make changes accordingly!

[sjorge]

According to Testflight this should be in 1.3 ... but It's not showing up for me. (The active devices dashboard is, so I'm definitely on the correct build)

[LePips]

Oops, I got the notes wrong. A new build should be up shortly.