Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] ListView + Grid Landscape Poster Padding #1213

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

JPKribs
Copy link
Member

@JPKribs JPKribs commented Aug 27, 2024

This is almost an exact copy/paste from iOS to tvOS. I added the Focus elements from the tvOS PosterButton to the LibraryRow elements in tvOS. Tested to work and the Cinematic Backdrop is unaffected.

While I was in here, I noticed that the landscape grid didn't have any item spacing, resulting in some overlap in grid + landscape. I added in spacing to mirror the grid + portrait.

Resolves: #687

tvOS Current Implementation

Simulator Screenshot - Apple TV 4K (3rd generation) - 2024-08-27 at 12 31 37

tvOS Implementation (1 Column, 2 Columns, 3 Columns)

321 ListViews

tvOS Settings

Settings ListViews

Landscape Posters Padding Changes

Fix Landscape Overlap

@JPKribs JPKribs mentioned this pull request Aug 27, 2024
LePips
LePips previously approved these changes Oct 7, 2024
Copy link
Member

@LePips LePips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine that this starts the work for list views but the libraries currently don't update when the view type changes. The logic on iOS PagingLibraryView is pretty complicated so when I take a deeper look at tvOS I'll get to that, as well as most likely refining some views/spacing.

@JPKribs
Copy link
Member Author

JPKribs commented Oct 11, 2024

I'm fine that this starts the work for list views but the libraries currently don't update when the view type changes.

Sounds good. I can look at that as well as part of this if you'd like? For now, I've just fixed the merge issues (and 1 missing label for Columns) but should otherwise be the same as prior. Let me know if there is anything else you'd like me to do on this!

@LePips LePips merged commit 498842b into jellyfin:main Oct 12, 2024
7 checks passed
@JPKribs JPKribs deleted the tvOSListView branch October 15, 2024 12:20
@JPKribs JPKribs added the enhancement New feature or request label Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tvOS - Library List View
2 participants