Media Item HD Attribute Source #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LePips
requested changes
Aug 3, 2024
There was a problem hiding this comment.
I was going to ask "please do tvOS as well" but I wonder if past me looked at the server, using only used the streams for tvOS and didn't do the same in iOS. isHDVideo differs from the server since I used 1920x1080 but I don't particularly care what definition we use.
So, let's just do what I did for tvOS and just do the streams instead. I'm too lazy to see what BaseItem.Height reflects on the server but my assumption is that it's from the streams.
LePips
approved these changes
Aug 6, 2024
LePips
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearing the TODO that suggests using the stream to determine if content supports HD. As a fallback I made the conditional an OR statement just to be safe.