Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Profile Image Selection #1061

Merged
merged 14 commits into from
May 22, 2024
Merged

User Profile Image Selection #1061

merged 14 commits into from
May 22, 2024

Conversation

LePips
Copy link
Member

@LePips LePips commented May 17, 2024

  • Implements user profile image selection from local device.

    • Will crop the image to 1:1 aspect ratio when uploading to server. IMO, this is how profile images should be stored anyways and the web should also be performing 1:1 cropping
    • Will cause all profile image views to redraw, getting the new image
      • the image tag is now part the url and will get the new image URL
  • Implements different caches for general and "branding" usage

    • User profile images and server splashscreens are in "branding" so that they can be used without a connection to the server and without being affected by other cache cleanup
    • Caches will have keys that ignore the host, which prevents duplicate images from the same server but with multiple urls
    • Closes Custom ImagePipeline/Cache for Splash Screen/User Profile Images #1052
  • Other polish and more TODOs

Simulator Screen Recording - iPhone 15 Pro - 2024-05-21 at 18 25 06

@LePips LePips marked this pull request as ready for review May 22, 2024 00:31
@LePips LePips requested a review from PangMo5 May 22, 2024 01:56
@LePips LePips enabled auto-merge (squash) May 22, 2024 01:57
@LePips LePips merged commit b2a31db into jellyfin:main May 22, 2024
3 of 4 checks passed
@LePips LePips deleted the user-photo-picker branch July 4, 2024 19:10
@LePips LePips added the enhancement New feature or request label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom ImagePipeline/Cache for Splash Screen/User Profile Images
2 participants