-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User/Server Sign In Redesign #1045
Merged
Merged
+9,084
−3,600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9474b89
to
310e781
Compare
PangMo5
approved these changes
May 15, 2024
This was referenced May 16, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually turned into a very large refactor and I also implemented more features so that I don't have to look at this area again for a while. However, there is still a lot that could be done as cleanup.
Redesign
The entire user/server connection flow has been redesigned. Instead of separate "screens" for the server list, user list, server connection, and user sign in, everything is now rooted into a single view for user selection.
Preview
Things don't look too much different, but this actually required a lot of work especially since I had the desire for the an feature of listing all connected users on the device. I have come to like this new flow since it made some other designs more simple, like not requiring the splash screen on the user sign in view, since everything is now a sheet presentation. However, I'm not entirely final on how the server selection works with a
Menu
. I went back and forth for a while between that and a sheet presentation but I'll have to think about it more. The switch wouldn't be much work.App Settings
The settings view accessible from here are settings meant for the app, and not necessarily settings for users while signed-in. This will receive some more work when I get to the Super User feature which will allow locked-down control of local device settings.
Other highlights
tvOS
tvOS again gets less work done, but even worse this time as this is all incomplete on tvOS. I got the basics done but lost motivation after I ran into many design problems with SwiftUI on tvOS. I had wanted to finally figure out what to do with tvOS users <-> Swiftfin user mapping but, again, lost motivation.
Even though there was work done with the database, I am sadly unsure if the issue of #776 is resolved since I didn't work much on tvOS. I didn't even tough my own device while working on it and only worked within the simulator.