Fix problem introduced in JAVASERVERFACES_SPEC_PUBLIC-1329, also cons… #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soul2zimate
force-pushed
the
WFLY-12491-2.3.9.SP
branch
from
566558b to
e7ec1cd
Compare
…ider Submitted value "" when EMPTY_STRING_AS_NULL_PARAM_NAME is enabled. Signed-off-by: Chao Wang <[email protected]>
soul2zimate
force-pushed
the
WFLY-12491-2.3.9.SP
branch
from
e7ec1cd to
0ed6a7e
Compare
|
Hi @fjuma would you mind to review this for https://issues.redhat.com/browse/JBEAP-17499 at your convenience time ? the details report and analysis is in upstream issue: eclipse-ee4j/mojarra#4550 |
|
@soul2zimate I added another comment on the upstream PR to try to get a review from them. My concern with this PR is that it is changing the expected values for test cases so ideally we should make sure that upstream is ok with this. |
|
Merged since upstream was approved and merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ider Submitted value "" when EMPTY_STRING_AS_NULL_PARAM_NAME is enabled.
(cherry picked from commit b1111429d0d66352ea8911c7abc210f1fec5684c)
(cherry picked from commit f3507c74b6fbb37797f3da235d8c0a88588b2e06)
issue: https://issues.jboss.org/browse/WFLY-12491
upstream issue: eclipse-ee4j/mojarra#4550
PR: eclipse-ee4j/mojarra#4643