Add executor.schedule(coro::task<void>) -> bool #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaldwin
force-pushed
the
issue-292/executor_add_schedule_task_fn
branch
from
aca6aad to
a7262ad
Compare
Completely removes coro::task_container, it isn't necessary as both executors already have m_size counters to track the orphaned task_self_deleting frames. * added executor concept spawn(task<void>) * added thread_pool and io_scheduler schedule(task<T> -> task<T>, this cannot be templated on the concept since the return type is dynamic as far as I can know how to do Closes #292
jbaldwin
force-pushed
the
issue-292/executor_add_schedule_task_fn
branch
from
a7262ad to
966eb9e
Compare
jbaldwin
commented
Feb 1, 2025
jbaldwin
commented
Feb 1, 2025
jbaldwin
commented
Feb 1, 2025
jbaldwin
commented
Feb 1, 2025
|
@breakds I've made some additional improvements, if you have a moment a review would be welcome, but no worries if not.
|
|
Hi Josh, Thanks for the change! Sorry that I am not able to review the code as I am on a trip without my laptop until next Wednesday. Please do not wait for me to submit the change, and I will read the change to learn from you a few days later. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes coro::task_container, it isn't necessary as both executors already have m_size counters to track the orphaned task_self_deleting frames.
Closes #292