Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RuboCop settings #2

Merged
merged 5 commits into from
Jul 24, 2022
Merged

Update RuboCop settings #2

merged 5 commits into from
Jul 24, 2022

Conversation

gemmaro
Copy link
Collaborator

@gemmaro gemmaro commented Jul 22, 2022

Changes:

  • Update RuboCop and config files
  • Add RuobCop extensions for Rake and RSpec
  • Minimal Ruby version is now 2.7
  • Apply RuboCop safe rules, except for unsafe rules

Memo:

.travis.yml says 2.3.0, so it might be the version.

Gem depends seems to require at least 2.4.0:

$ ruby -v            
ruby 2.3.0p0 (2015-12-25 revision 53290) [x86_64-darwin21]

$ bundle
Fetching gem metadata from https://rubygems.org/...........
Resolving dependencies...
listen-3.7.1 requires ruby version >= 2.4.0, which is incompatible with the current version, ruby 2.3.0p0

gemmaro added 5 commits July 23, 2022 11:02

Verified

This commit was signed with the committer’s verified signature.
Also set minimal Ruby version at stable version 2.7.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
Ruby v2.6 or before are dropped from supported versions for EOL (#4).
@gemmaro gemmaro marked this pull request as ready for review July 23, 2022 02:08
Copy link
Owner

@iyuuya iyuuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gemmaro gemmaro merged commit d6d541c into iyuuya:develop Jul 24, 2022
@gemmaro gemmaro deleted the update/rubocop branch July 24, 2022 01:02
@gemmaro gemmaro restored the update/rubocop branch July 28, 2022 22:42
@gemmaro gemmaro deleted the update/rubocop branch July 28, 2022 22:43
@gemmaro gemmaro mentioned this pull request Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants