Added Timeline #188

Mond1c · 2024-07-18T12:26:16Z

No description provided.

github-actions · 2024-07-19T06:33:53Z

Playwright tests screens

github-actions · 2024-07-20T07:06:15Z

Playwright tests screens

kunyavskiy · 2024-07-20T07:28:03Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

+                            TimeLineRunInfo.InProgress(info.time, info.problemId)
+                        }
+                    }
+                }.filterNotNull()


You can use mapNotNull instead

kunyavskiy · 2024-07-20T07:28:48Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

+
+                        is RunResult.IOI -> {
+                            val ioiResult = info.result as RunResult.IOI
+                            TimeLineRunInfo.IOI(info.time, info.problemId, ioiResult.scoreAfter)


Not sure if we should use scoreAfter or score difference here. With score after, maybe we can show only improvements.

kunyavskiy · 2024-07-20T07:29:20Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

+                        is RunResult.ICPC -> {
+                            val icpcResult = info.result as RunResult.ICPC
+                            if (!acceptedProblems.contains(info.problemId)) {
+                                if (icpcResult.verdict == Verdict.Accepted) {


It's better to use .isAccepted instead of equality check

kunyavskiy · 2024-07-20T07:32:02Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

@@ -28,13 +29,52 @@ fun Route.configureOverlayRouting() {
    flowEndpoint("/mainScreen") { DataBus.mainScreenFlow.await() }
    flowEndpoint("/contestInfo") { DataBus.currentContestInfoFlow() }
    flowEndpoint("/runs") { DataBus.contestStateFlow.await().map { it.runsAfterEvent.values.sortedBy { it.time } } }
+    webSocket("/teamRuns") {
+        val teamIdStr = (incoming.receive() as? Frame.Text)?.readText()


If we don't want to be able to subscribe to more teams over the existing webSocket, why send this instead of adding to name?

kunyavskiy · 2024-07-20T07:37:04Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

+        }
+        val teamId = teamIdStr.toTeamId()
+        sendJsonFlow(DataBus.contestStateFlow.await().map { state ->
+            state.runsAfterEvent.values.filter { it.teamId == teamId }


I think this is a bit too time-consuming. Probably we should process events ourselves, ignoring events except known teams.

Something like (didn't run or test to be compilable, just as main idea)

contestStateFlow .mapNotNull { (it.event as? RunEvent)?.newInfo } .runningFold(persistentMapOf<RunId, RunInfo>()) { acc, it -> if (it.teamId == teamId) acc.put(it.id, it) else if (it.runId in acc) acc.remove(it.runId) else acc } .distintUntilChanged { a, b -> a === b } .map { it.value.sortedBy { it.time } }

github-actions · 2024-07-21T08:34:05Z

Playwright tests screens

github-actions · 2024-07-21T11:51:10Z

Playwright tests screens

kunyavskiy · 2024-07-24T09:49:54Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

+        val acceptedProblems = mutableSetOf<ProblemId>()
+        val allRuns = mutableMapOf<RunId, RunInfo>()
+        DataBus.contestStateFlow.await().first().runsAfterEvent.values
+            .filter { teamId == it.teamId && it.time.toLong(DurationUnit.MILLISECONDS) != 0L }


!= Duration.ZERO

kunyavskiy · 2024-07-24T09:50:32Z

src/backend/src/main/kotlin/org/icpclive/overlay/Routing.kt

+        val teamId = teamIdStr.toTeamId()
+        val acceptedProblems = mutableSetOf<ProblemId>()
+        val allRuns = mutableMapOf<RunId, RunInfo>()
+        DataBus.contestStateFlow.await().first().runsAfterEvent.values


Tbh, I don't like how it ended, but let's proceed with this, I'll rewrite this part later, not sure how exactly.

kunyavskiy · 2024-07-24T09:51:26Z

src/frontend/overlay/src/components/organisms/holder/TimeLine.jsx

+        return (
+            <ProblemWrap left={left + "%"}>
+                <Circle color={getColor(problemResult)}>
+                    <Label darkText={darkText} isBold={problemResult.type === "IN_PROGRESS"}>


Let's use generated ts constants instead. You can add class into list in build.gradle.kts ins scheme generator, if it is not generated.

github-actions · 2024-07-24T18:26:23Z

Playwright tests screens

kbats183 · 2024-07-28T17:42:41Z

src/frontend/overlay/src/components/organisms/holder/TimeLine.jsx

+const TextWithAnimation = styled.div`
+    animation: ${ChangeTextAnimation} 10s infinite;
+    justify-content: center;
+    position: absolute;
+    align-items: center;
+    text-align: center;
+`;
+
+const TextWithAnimation2 = styled.div`
+    animation: ${ChangeTextAnimation2} 10s infinite;
+    justify-content: center;
+    position: absolute;
+    align-items: center;
+    text-align: center;
+    font-size: 12px;


Может, придумать какие-то более разумные названия?

kbats183 · 2024-07-28T17:44:02Z

src/frontend/overlay/src/components/organisms/holder/TimeLine.jsx

@@ -0,0 +1,182 @@
+import React, { useEffect, useState } from "react";


Может, сразу назвать файл TimeLine.tsx и навесить типы?

kbats183 · 2024-07-28T17:45:05Z

src/frontend/overlay/src/components/organisms/holder/TimeLine.jsx

+    const getColor = (problemResult) => {
+        if (problemResult.type === RunResult.Type.IN_PROGRESS) {
+            return c.VERDICT_UNKNOWN;
+        } else if (problemResult.type === RunResult.Type.ICPC) {
+            if (problemResult.isAccepted) {
+                return c.VERDICT_OK;
+            } else {
+                return c.VERDICT_NOK;
+            }
+        } else {
+            const task = contestInfo.problems.find(info => info.letter === problemResult.problemId);
+            return getIOIColor(problemResult.score, task?.minScore, task?.maxScore);
+        }
+    };


Наверное, можно наружу от функции компонента вынести? Ну или useMemo?

kbats183 · 2024-07-28T17:47:50Z

src/frontend/overlay/src/components/organisms/holder/TimeLine.jsx

+    useEffect(() => {
+        const socket = new WebSocket(c.BASE_URL_WS + "/teamRuns/" + teamId);
+        socket.onopen = function () {
+            console.log("WebSocket is open");


Здесь и ниже может быь лучше console.debug + добавить какую-то информацию про то, что за вебсокет?

github-actions · 2024-07-30T07:03:09Z

Playwright tests screens

Mond1c marked this pull request as draft July 18, 2024 12:26

kbats183 force-pushed the timeline branch from f346d71 to 0eee34f Compare July 18, 2024 17:09

Mond1c force-pushed the timeline branch 2 times, most recently from e698af6 to e8b8b80 Compare July 19, 2024 06:28

kunyavskiy reviewed Jul 20, 2024

View reviewed changes

Mond1c marked this pull request as ready for review July 21, 2024 08:29

kunyavskiy reviewed Jul 24, 2024

View reviewed changes

Mond1c added 13 commits July 24, 2024 21:01

start timeline

9f5d309

added problems letters

f62e28c

timeline

681a83b

clean up

8ab18be

added websocket support

ec0fd9f

fix api

5743d05

fix timeline design

5fa5457

add constants

7649832

ignore run after accepted verdict

4e8ca23

delete RUNS_URL

4f0d458

refactor backend

b080ba1

ioi support

afbc22b

backend rework

a05a4f8

Mond1c added 4 commits July 24, 2024 21:01

design improvements

0b713c7

refactor

d239d00

refactor

5739e4b

fix const

f1ab31a

Mond1c force-pushed the timeline branch from d852943 to f1ab31a Compare July 24, 2024 18:15

Mond1c added 2 commits July 24, 2024 21:17

fix admin linter

d27250e

fix api

2ad8254

kbats183 approved these changes Jul 28, 2024

View reviewed changes

Mond1c added 2 commits July 30, 2024 09:48

some refactor

6a18c7c

move to typescript

16dba7b

Mond1c merged commit 2ab162a into main Jul 30, 2024
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Timeline #188

Added Timeline #188

Mond1c commented Jul 18, 2024

github-actions bot commented Jul 19, 2024

github-actions bot commented Jul 20, 2024

kunyavskiy Jul 20, 2024

kunyavskiy Jul 20, 2024

kunyavskiy Jul 20, 2024

kunyavskiy Jul 20, 2024

kunyavskiy Jul 20, 2024 •

edited

Loading

github-actions bot commented Jul 21, 2024

github-actions bot commented Jul 21, 2024

kunyavskiy Jul 24, 2024

kunyavskiy Jul 24, 2024

kunyavskiy Jul 24, 2024

github-actions bot commented Jul 24, 2024

kbats183 Jul 28, 2024

kbats183 Jul 28, 2024

kbats183 Jul 28, 2024

kbats183 Jul 28, 2024

github-actions bot commented Jul 30, 2024

		@@ -0,0 +1,182 @@
		import React, { useEffect, useState } from "react";

Added Timeline #188

Added Timeline #188

Conversation

Mond1c commented Jul 18, 2024

github-actions bot commented Jul 19, 2024

github-actions bot commented Jul 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kunyavskiy Jul 20, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 21, 2024

github-actions bot commented Jul 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 24, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 30, 2024

kunyavskiy Jul 20, 2024 •

edited

Loading