Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run id from cds #160

Merged
merged 2 commits into from
Mar 17, 2024
Merged

Use run id from cds #160

merged 2 commits into from
Mar 17, 2024

Conversation

kunyavskiy
Copy link
Contributor

No description provided.

@kunyavskiy kunyavskiy requested a review from kbats183 March 17, 2024 09:25
@@ -47,21 +47,21 @@ class Storage {
)
val voted = Votes.selectAll()
.where { Votes.chatId eq chatId }
.map { Vote.wrapRow(it).id.value }
.map { Vote.wrapRow(it).runId }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there was some bug here. vote ids and run ids was messed up. But I don't really sure what's going on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be
I want to rewrite this code

@@ -47,21 +47,21 @@ class Storage {
)
val voted = Votes.selectAll()
.where { Votes.chatId eq chatId }
.map { Vote.wrapRow(it).id.value }
.map { Vote.wrapRow(it).runId }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be
I want to rewrite this code

@kunyavskiy kunyavskiy merged commit 2341320 into main Mar 17, 2024
1 check passed
@kunyavskiy kunyavskiy deleted the no-run-id branch April 21, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants