do not format advanced json in admin panel #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunyavskiy
reviewed
Mar 17, 2024
| call.respondFile(Config.cdsSettings.advancedJsonPath.toFile()) | ||
| try { | ||
| call.respondFile(Config.cdsSettings.advancedJsonPath.toFile()) | ||
| } catch (e: IOException) { |
There was a problem hiding this comment.
I'd say it is better to check on exists() instead of catching an exception. IOException, can occur because of different reasons unrealaed to files (like, failing to write answer to socket)
irdkwmnsb
reviewed
Mar 17, 2024
| @@ -14,11 +14,11 @@ export const useLocalStorageState = (key, defaultValue) => { | |||
| }; | |||
|
|
|||
| export const createApiPost = (apiUrl) => | |||
| function (path, body = {}, method = "POST") { | |||
| function (path, body = {}, method = "POST", sendRaw = false) { | |||
There was a problem hiding this comment.
At one point in time we might have a huge number of parameters for this function.
I think there are two nice solutions to keeping the code nice and tidy:
- Use 3rd party library like Axios
- Move all parameters to a single object and invoke the function like this:
apiPost("", constn, "POST", {
sendRaw: true
});That way we can have more parameters that are not required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.