Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HULUROKU-7877] Replace brs package with @rokucommunity/brs version 0.45.2 #141

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

gregomite
Copy link
Collaborator

@gregomite gregomite commented Jan 14, 2025

Jira: HULUROKU-7877

  • Replace the "brs" package with "@rokucommunity/brs" in package.json
  • Use @rokucommunity/brs version 0.45.2 (later versions introduce issues with roca's unit tests)
  • Update roca typescript files to use the new namespace "@rokucommunity/brs"

@Nowele
Copy link
Collaborator

Nowele commented Jan 15, 2025

Should we increase the version of roca as well here to 0.26.0?

"name": "@hulu/roca",
  "version": "0.25.0

@Nowele Nowele requested a review from tjhighpoint January 15, 2025 21:53
@Nowele
Copy link
Collaborator

Nowele commented Jan 15, 2025

ran yarn install then yarn run-s clean build test

 PASS  test/e2e/parameterized/parameterized.test.js
 PASS  test/e2e/simple-suites/simple-suites.test.js
 PASS  test/e2e/assert/assert.test.js
 PASS  test/e2e/before-after/before-after.test.js
 PASS  test/e2e/selection/selection.test.js
 PASS  test/reporter/jest-reporter.test.ts (5.165 s)
 PASS  test/runner/file-match.test.ts (5.62 s)

Test Suites: 7 passed, 7 total
Tests:       33 passed, 33 total
Snapshots:   0 total
Time:        6.079 s

@gregomite
Copy link
Collaborator Author

gregomite commented Jan 15, 2025

I think the version bump should be its own commit when we're ready to tag the ROCA project.

@nadiapadalka
Copy link
Collaborator

@Nowele, maybe we need to merge this PR and the later update should be done in the separate Pr?

@gregomite gregomite merged commit 1a16845 into hulu:main Jan 30, 2025
3 checks passed
@gregomite gregomite deleted the HULUROKU-7877 branch February 1, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants