Update to new Metafacture dependency; use Java 11 #130
Conversation
Don't forget to "export JAVA_HOME=$yourPath".
dr0i
changed the title
|
Discussed with @fsteeg :
|
|
@dr0i We will need the newest Metafacture versions soon and, thus, have to switch to Java 11. Can you please prioritize this? (Keep in mind: If this gets too complex, we could also evaluate other approaches that don't require Java11 for RPB.) |
Am I understanding this correctly? The elasticsearch 1.7.5 dependency is not available for Java 11? |
Yes - I think so. |
|
The build here seems to fail for an unrelated reason: https://github.com/hbz/rpb/actions/runs/13180450569/job/36789667677#step:5:1937
|
|
Ah, ok. Have you tried build it locally with installed mf-fix 1.2.0? |
|
No, I have never worked on this issue. Also, it contains no changes about the Java version. |
|
I tried it in another context: https://github.com/hbz/rpb/pull/105/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721 The build with 1.2.0 works fine here. PS: I was so bold to push the adjustments to the build.yml |
- We need Java 11 for using the latest Metafacture release - Elasticsearch 1.x.x does not support Java 11, Elasticsearch 2.x.x does not support dots in field names, 5.6.16 does both
…UpdateMFDependencies
fsteeg
force-pushed
the
129-switchToJava11AndUpdateMFDependencies
branch
from
acb39fd to
e706032
Compare
Get tag in GitHub action, add local file to avoid release build (which requires signing), use resulting SNAPSHOT in build.sbt
|
Assigning @dr0i for review. Your original statement about Elasticsearch being the problem was actually true, even though the build here did not show that (you probably tested it locally?), since the problem does not appear on running the tests, but only on I did some remaining changes for switching to Java 11 and updated the Elasticsearch version for the embedded index to 5.6.16 (Elasticsearch 1.x does not support Java 11, Elasticsearch 2.x does not support dots in field names, 5.x does both). |
|
Deployed to test: |
| run: | | ||
| git clone https://github.com/metafacture/metafacture-fix.git -b 0.7.1 | ||
| cd metafacture-fix | ||
| touch .temp # don't build release, which requires signing |
|
+1 |
|
(While you are at it - could you also heave other apps to Java 11, like hbz/nwbib#665 ? If they have similar underlying mechanism ... Would be cool if we would only have one Java version at our servers :) ) |
Yes, that would be nice, and since it's possible here, it seems like it's a realistic goal. But still a little project, for which we should set aside some time, because it's not just nwbib, but also lobid-gnd and lobid-organisations. We could discuss this in our quarterly planning meeting on Monday. |
See #129 & https://jira.hbz-nrw.de/browse/RPB-266.
Don't forget to "export JAVA_HOME=$yourPath".
AFAIK the only problem is the "org.elasticsearch" % "elasticsearch" % "1.7.5" dependency which is used by Classification.java as intrnal lookup for classifications.