Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NTP-based system time check to Wink #18

Closed
harnyk opened this issue May 15, 2023 · 0 comments · Fixed by #19
Closed

Add NTP-based system time check to Wink #18

harnyk opened this issue May 15, 2023 · 0 comments · Fixed by #19

Comments

@harnyk
Copy link
Owner

harnyk commented May 15, 2023

To ensure that Wink works accurately, it is critical that the system time on the client machine is correct. Misalignment can cause issues with the correct functioning of the application.

To prevent such issues, it is proposed to add a feature to Wink that would compare the system time on the client machine with an absolute time reference from an NTP server. If the time difference is significant (e.g., more than 1 minute), Wink should fail with an appropriate error message.

This feature should be configurable through the application's configuration. Two new configuration settings should be introduced:

  1. A boolean setting to enable or disable the time check (e.g., check_time: true/false).
  2. A string setting to specify the NTP server to use for time checks (e.g., ntp_server: "pool.ntp.org").

If the ntp_server setting is not specified but check_time is enabled, Wink should use the default NTP server (pool.ntp.org).

Acceptance Criteria:

  • Wink has a configuration option to enable or disable the system time check.
  • Wink has a configuration option to specify the NTP server for time checks.
  • If the time check is enabled, Wink compares the system time on the client machine with the time from the specified (or default) NTP server.
  • If the time difference is significant, Wink fails with an error message.
  • Documentation is updated to include information about the new configuration options and the time check feature.
harnyk pushed a commit that referenced this issue May 18, 2023
@harnyk harnyk mentioned this issue May 18, 2023
@harnyk harnyk linked a pull request May 18, 2023 that will close this issue
harnyk pushed a commit that referenced this issue May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant