Add thymeleaf plugin configurer #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This starter adds a basic
IPluginConfigurer,SbpThymeleafConfigurerthat Thymeleaf uses to load templates from the plugins, to be honest, I have no idea how gradle works so I couldn't get the project to compile but hopefully, since the code is fairly simple, I'm not missing anything, let me know if any changes are required.As a basic implementation it hard-codes the suffix and prefix for the templates in the plugin so its limited to
/templates/as the folder and.htmlfor the templates, I would like to improve this, do you think having individual configuration for each plugin is worth pursuing or should all the plugins just "inherit" the main app template resolver configuration?Salutations