Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve projection of flexible array members #959

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

halildurmus
Copy link
Owner

Description

Related Issue

Fixes #399

Type of Change

  • πŸš€ feat – New feature (non-breaking change that adds functionality)
  • πŸ› οΈ fix – Bug fix (non-breaking change that fixes an issue)
  • ❌ ! – Breaking change (fix or feature that causes existing functionality to change)
  • ⚑ perf – Performance improvement
  • 🧹 refactor – Code refactor (no functionality change)
  • πŸ“ docs – Documentation update
  • 🎨 style – Code style changes (formatting, renaming, etc.)
  • πŸ§ͺ test – Test update or addition
  • πŸ”§ build – Build related changes
  • βœ… ci – CI related changes
  • πŸ—‘οΈ chore – Chore (maintenance, non-production code change)
  • ◀️ revert – Revert a previous commit

@github-actions github-actions bot added package: generator Issue with package:generator package: win32 Issue with package:win32 example Sample code and demos labels Feb 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 62.21%. Comparing base (de03f0f) to head (33eb561).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/generator/lib/src/projection/field.dart 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #959      +/-   ##
==========================================
+ Coverage   61.64%   62.21%   +0.56%     
==========================================
  Files          35       36       +1     
  Lines        1176     1191      +15     
==========================================
+ Hits          725      741      +16     
+ Misses        451      450       -1     
Flag Coverage Ξ”
generator 63.49% <46.15%> (+0.30%) ⬆️
win32 60.44% <100.00%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Ξ”
packages/win32/lib/src/extensions/_internal.dart 100.00% <100.00%> (ΓΈ)
packages/generator/lib/src/projection/field.dart 53.33% <46.15%> (+8.88%) ⬆️

@halildurmus halildurmus merged commit 776e739 into main Feb 18, 2025
17 checks passed
@halildurmus halildurmus deleted the flexible-array-members branch February 18, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Sample code and demos package: generator Issue with package:generator package: win32 Issue with package:win32
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve projection of Flexible Array Members
2 participants