PyF as a source plugin #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new plugin, activable with `-fplugin=PyF.Plugin` can detect the usage of `fmt` and replace the template haskell by pure haskell code at plugin time. In the future, it could be possible to simplify the code (e.g. no more template Haskell, no more `Meta.hs`), give nicer feedbacks (instance errors can be localized on the real expression) and it should be faster because plugin do not require the dynamic logic required for template haskell.
`String` inside the AST. TODO: restore correct locations.
By replacing the remaining QQ we have in the source code of nova in
silico, I aim at having faster and more robust HLS.
```
git grep -o -h '\[[a-zA-Z0-9]\+|' **/*.hs | sort | uniq -c | sort -n -k1
2 [strTrim|
6 [fmtTrim|
23 [duration|
51 [aesonQQ|
231 [fmt|
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First implementaiton of #49