Bump ghc912 fix ghc910 #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
guibou
commented
Jan 3, 2025
guibou
commented
- Fix test with GHC 9.10
- Fix build with GHC 9.12
- A lot af cleanup in the nix logic / formatting / testing / ... See indiidual commits.
For *reasons* the test are failing on GHC 9.10 because the amount of whitespaces changed. The golden test logic now just trim the content. Close #142.
Note that in order to get correct behavior, I had to move the generated (`.hi`, `.o`) files into a temporary directory.
- replace `pyf_all` by `nix flake check`, this is simpler. - clean the naming in the flake (addressing warnings from `nix flake check`) - replace the `source` regex by `./.` which always uses what's checkouted by nix. The cost is that a change in nix forces a rebuild of the complete project, but code is simpler.
- Mostly, I removed the `default_pyf` and instead use the `default` nix attribute which uses `haskellPackages`, so it is always the default.
This was a lot of code, mostly not used.
guibou
force-pushed
the
bump_ghc912_fix_ghc910
branch
from
37b8857 to
8117a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.