Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quoteLink): add quote link additional plugin #667

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kseniya57
Copy link
Contributor

@kseniya57 kseniya57 commented Mar 5, 2025

Added the quote link extension experiment https://preview.gravity-ui.com/md-editor/667/?path=/story/experiments-quotelink--story

The functionality for editing works with restrictions, without a button (I've left it for improvements so far), you can click on the upper-left corner

Screenshot 2025-03-05 at 10 16 01

@kseniya57 kseniya57 self-assigned this Mar 5, 2025
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@makhnatkin
Copy link
Collaborator

  1. Please look at why the cyclic dependencies have increased and try to change the code so that the number of these dependencies does not increase
  2. When clicking on the quote button, a number of problems arise - the cursor is missing, the first line flickers, the pointer cursor is reflected. Please fix these problems, or add explanatory comments to the story about why the case with flow by clicking on the quote button will not be in a real project

Copy link
Collaborator

@makhnatkin makhnatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test the input rule

@kseniya57 kseniya57 force-pushed the quote-link branch 2 times, most recently from 8fe64ad to c1b96c3 Compare March 5, 2025 14:11
@kseniya57 kseniya57 requested a review from makhnatkin March 5, 2025 14:17
@kseniya57 kseniya57 force-pushed the quote-link branch 2 times, most recently from 81b7420 to 24136b6 Compare March 6, 2025 08:43
@makhnatkin
Copy link
Collaborator

During testing, I discovered a couple of bugs that need to be fixed, see the video.

cant-delete.mov
delete-artefact.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants