fix: added z-index to mode help tooltip and z-index system (issue #298) #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
dpolevodin
changed the title
makhnatkin
reviewed
Feb 13, 2025
|
|
||
| .tooltip { | ||
| @include mixins.z-index('forefront'); | ||
| } |
| 'img-settings-button': 2, | ||
| 'table-view-button': 100, | ||
| 'table-cell-button': 110, | ||
| 'sticky-toolbar': 990, |
There was a problem hiding this comment.
- header sticky toolbar+
- header sticky toolbar
- context toolbar+ (popups, hints)
- context toolbar
- suggest popup+ (for hints), (
...buttons menu) - suggest popup
- block panel popup
context is popup from text selection
suggest is /, :
There was a problem hiding this comment.
if you need to change z-index in uikit component use style https://github.com/gravity-ui/uikit/blob/main/src/components/types.ts#L4C5-L4C27
like this:
style={{
// ...otherStyles,
zIndex: var(--md-editor-z-index-level-suggest);
}}
…into fix/tooltip-hidden-under-toolbar
…/dpolevodin/markdown-editor into fix/tooltip-hidden-under-toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #298
z-index for the sticky-toolbar has been lowered from 2000 to 990, since the HelpMark tooltip index is set to 1000 in uikit
Added z-index system and updated readme.
Changed current z-index values in project by z-index mixin