Recognize jlcxx::Array
and jlcxx::ArrayRef
as natively supported
#60
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a speculative attempt to add an override to theauto_veto
feature. It's useful in cases where there are many functions that shouldn't be wrapped that are correctly vetoed byauto_veto
, but there's a few that should be wrapped anyway.My motivation is that there there's a function I'm defining in a custom header that returns ajlcxx::Array
. CxxWrap already supports this so nothing extra is required, but wrapit will create wrappers forjlcxx::Array
anyway and insert them into the module. I don't want this to happen so I tried addingjlcxx::Array
to the veto list, but because ofauto_veto
my function was removed as well. And I don't want to disableauto_veto
because there are many dozens of functions that it correctly removes. With this PR I can setveto_overrides_list = "veto_overrides.txt"
and allow only that one function to get throughauto_veto
.An alternative approach would be to add built-in support for the
jlcxx::Array
/jlcxx::ArrayRef
types, but I figured this is more general so it might be more useful. What do you think?