Enable Web Connection menu in all list views #2008
Conversation
gramps/gui/views/listview.py
Outdated
| @@ -1066,7 +1065,7 @@ def _button_press(self, obj, event): | |||
| self.at_popup_menu.append(qr_ui) | |||
|
|
|||
| # Web Connects | |||
| if self.QR_CATEGORY == CATEGORY_QR_PERSON: | |||
| if self.QR_CATEGORY > -1: | |||
There was a problem hiding this comment.
What is -1? Is this leaking some implementation details about categories? Is there a way to:
| if self.QR_CATEGORY > -1: | |
| if self.QR_CATEGORY != NO_CATEGORY_ALLOWED: |
There was a problem hiding this comment.
I copied this line from the quick reports section above, but I'll see if there is an easy way to improve this.
There was a problem hiding this comment.
I've changed the code for both the quick reports and web connects to use CATEGORY_QR_MISC.
There was a problem hiding this comment.
CATEGORY_QR_MISC quickviews are a challenge to document in the wiki.
Can you suggest a workflow for discovering where the feature is used? Maybe we can compose a "Usage" section caveat?
(Such as: "This QuickView is not called directly by a GUI control. Instead, it is a "helper" for other features and the list of places where it is used is constantly changing. A partial list follows. Click here to search GitHub for modules that currently call the ____ QuickView.")
Nick-Hall
merged commit 8eaa720
into
gramps-project:maintenance/gramps60
At present the Web Connection menu is restricted to the person list views. Removing this restriction would allow further development of the Web Connection functionality in addons.
This type of change would not normally be allowed in a maintenance branch, but since the change is small we could possibly consider it in this case.