Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled state in AutoSizeInput #97551

Merged
merged 1 commit into from
Dec 6, 2024
Merged

GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled state in AutoSizeInput #97551

merged 1 commit into from
Dec 6, 2024

Conversation

itsmylife
Copy link
Contributor

@itsmylife itsmylife commented Dec 6, 2024 •
edited
Loading

Reverts #96696

It revert the custom legend editing issue.

Steps to reproduce

  • Goto explore (top explore)
  • select prometheus datasource - in fpdev stack, I chose cloudfwdev-prom
  • type in a metric - eg aws_apigateway_info
  • open Options
  • Select legend
  • choose custom
  • type in field for legend - aws_account
  • run query - this works and legend shows aws_account values
  • try to delete legend - as you delete last char it redisplays - the label text can be edited

Revert will fix the issue.

@itsmylife itsmylife requested a review from a team as a code owner December 6, 2024 12:19
@itsmylife itsmylife requested review from joshhunt and aocenas and removed request for a team December 6, 2024 12:19
joshhunt
joshhunt approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@joshhunt joshhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shame. I'll revisit this.

@github-actions github-actions bot added this to the 11.5.x milestone Dec 6, 2024
@itsmylife itsmylife added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes add to changelog and removed no-changelog Skip including change in changelog/release notes labels Dec 6, 2024
@itsmylife itsmylife changed the title Revert "GrafanaUI: Fix inconsistent controlled/uncontrolled state in AutoSizeInput" GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled state in AutoSizeInput Dec 6, 2024
@itsmylife itsmylife enabled auto-merge (squash) December 6, 2024 12:35
@itsmylife itsmylife merged commit 9f3073f into main Dec 6, 2024
34 checks passed
@itsmylife itsmylife deleted the revert-96696-joshhunt/autosizeinput-controlled-state branch December 6, 2024 12:37
joshhunt added a commit that referenced this pull request Dec 6, 2024
@joshhunt
Revert "GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled s…
0ae041d 
…tate in AutoSizeInput (#97551)"

This reverts commit 9f3073f.
@joshhunt joshhunt mentioned this pull request Dec 6, 2024
Merged
@NWRichmond NWRichmond mentioned this pull request Dec 9, 2024
Closed
@matyax matyax mentioned this pull request Dec 10, 2024
Closed
tskarhed pushed a commit that referenced this pull request Dec 11, 2024
@joshhunt
AutoSizeInput: fix inconsistent input value state (#97575)
cdc7c1c 
* Revert "GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled state in AutoSizeInput (#97551)"

This reverts commit 9f3073f.

* Fix defaultValue being used if the user cleared the inputy
shubhankarunhale pushed a commit to shubhankarunhale/grafana that referenced this pull request Dec 27, 2024
@itsmylife @shubhankarunhale
GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled state in …
57d3a90 
…AutoSizeInput (grafana#97551)

Revert "GrafanaUI: Fix inconsistent controlled/uncontrolled state in AutoSize…"

This reverts commit cd86546.
shubhankarunhale pushed a commit to shubhankarunhale/grafana that referenced this pull request Dec 27, 2024
@joshhunt @shubhankarunhale
AutoSizeInput: fix inconsistent input value state (grafana#97575)
9dd5d21 
* Revert "GrafanaUI: Revert: Fix inconsistent controlled/uncontrolled state in AutoSizeInput (grafana#97551)"

This reverts commit 9f3073f.

* Fix defaultValue being used if the user cleared the inputy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshhunt joshhunt joshhunt approved these changes

@aocenas aocenas Awaiting requested review from aocenas aocenas is a code owner automatically assigned from grafana/grafana-frontend-platform

Assignees
No one assigned
Labels
add to changelog area/frontend no-backport Skip backport of PR
Projects
None yet
Milestone
11.5.x
Development

Successfully merging this pull request may close these issues.
2 participants
@itsmylife @joshhunt