-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logs Panel: Limit displayed characters to MAX_CHARACTERS #96997
Conversation
A smaller limit might be used, but that opens a whole different discussion, as this is meant to improve how the panel responds under extreme conditions. Some background about the existing limit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point @svennergr. I also felt that something was missing. How about: Uses a secondary type button. I think primary is too flashy: As far as I know, spaces are not used before ellipsis, but also tried it and looks weird. Keep in mind that this is only visible after 100k characters, though. |
Yeah! Let's go with fill. |
* LogRowMessage: limit displayed characters to MAX_CHARACTERS * LogRowMessage: update ellipsis text * Formatting * Revert test change * LogRowMessage: fix conditional * Extract translations * LogRowMessage: use button for ellipsis * Revert test change * Change fill to outline * Revert test change
Closes #96020
As a measure to improve how the logs panel responds when dealing with excessively long lines, this PR limits the displayed characters to MAX_CHARACTERS, which is currently 100.000.
Demo.mov