[v11.3.x] Alerting: Fix setting datasource uid, when datasource is string in old version #96273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
grafana-delivery-bot
bot
requested review from
gillesdemey,
tomratcliffe,
konrad147 and
soniaAguilarPeiron
grafana-delivery-bot
bot
added
add to changelog
area/alerting
gillesdemey
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2f58311 from #96085
What is this feature?
This PR fixes a rare bug that happens on old rules created before uids where introduced in datasources.
In particular when trying to set datasource uid, and the datasource hapens to be an string instead of an object.
It seems a regression after this PR was merged (that was actually fixing another edge usecase)
Why do we need this feature?
It's a bug.
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #96040
Special notes for your reviewer:
Please check that: