Canvas: Improved tooltip #90162
Merged
Canvas: Improved tooltip #90162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adela-almasan
added
add to changelog
area/panel/canvas
|
Great work on this!! I am wondering if we should also consider showing the timestamp (if relevant) in the tooltip as well as we have gotten this as a request before 🤔 could be a next step though |
adela-almasan
requested review from
leeoniya and
nmarrs
and removed request for
a team
nmarrs
approved these changes
Jul 9, 2024
| <div className={style.wrapper}>{renderDataLinks()}</div> | ||
| <VizTooltipHeader item={headerItem} isPinned={scene.tooltip.isOpen!} /> | ||
| {element.data.text && <VizTooltipContent items={contentItems} isPinned={scene.tooltip.isOpen!} />} | ||
| <VizTooltipFooter dataLinks={element.data?.links} /> |
There was a problem hiding this comment.
standardized tooltips coming in strong here 💪
|
Let's hold off on merging this until we've discussed how we want to handle which elements display a tooltip (see this internal slack discussion) |
nmarrs
reviewed
Jul 9, 2024
Comment on lines
284
to
285
| const canShowElementTooltip = !this.isEditingEnabled; | ||
|
|
There was a problem hiding this comment.
Maybe something like if we go with more exclusive method for displaying tooltips
Suggested change
| const canShowElementTooltip = !this.isEditingEnabled; | |
| const isTooltipValid = (this.tooltip?.element?.data?.links?.length ?? 0) > 0 || this.tooltip?.element?.data?.field; | |
| const canShowElementTooltip = !this.isEditingEnabled && isTooltipValid; |
ryantxu
pushed a commit
that referenced
this pull request
Jul 11, 2024
Co-authored-by: nmarrs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Screen.Recording.2024-07-09.at.2.51.29.PM.mov
TODO:
Please check that: