llcppg/ast:rvalue reference #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
=======================================
Coverage 97.56% 97.56%
=======================================
Files 19 19
Lines 4648 4648
=======================================
Hits 4535 4535
Misses 96 96
Partials 17 17 ☔ View full report in Codecov by Sentry. |
xushiwei
reviewed
Aug 20, 2024
chore/llcppg/ast/ast.go
Outdated
| @@ -158,9 +158,11 @@ func (*PointerType) exprNode() {} | |||
|
|
|||
| // ------------------------------------------------ | |||
|
|
|||
| // X& | |||
| // X& (lvalue) | |||
| // X&& (rvalue) | |||
There was a problem hiding this comment.
这是两个完全不同的类型，没必要用同一个类型。如果要合并，那么 PointerType 也需要合并过来。
- PointerType
- LvalueRefType
- RvalueRefType
There was a problem hiding this comment.
这是两个完全不同的类型，没必要用同一个类型。如果要合并，那么 PointerType 也需要合并过来。
- PointerType
- LvalueRefType
- RvalueRefType
Updated
luoliwoshang
force-pushed
the
llcppg/ast/refertype
branch
from
87d7a9b to
e3fefde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.