Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libuv async #673

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Add libuv async #673

merged 2 commits into from
Aug 7, 2024

Conversation

cpunion
Copy link
Contributor

@cpunion cpunion commented Aug 7, 2024

No description provided.

Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (e6b4deb) to head (a44bb35).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #673   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files          19       19           
  Lines        4584     4584           
=======================================
  Hits         4473     4473           
  Misses         94       94           
  Partials       17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

c/libuv/error.go Outdated
@@ -8,6 +8,19 @@ import (
"github.com/goplus/llgo/c/syscall"
)

type aErrno struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个不在这个包实现

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

c/libuv/async.go Outdated

type Async = *aAsync

type aAsync struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

包装不在这个包来做

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个包要确保原汁原味,可以通过工具自动生成。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@cpunion cpunion force-pushed the libuv-async branch 2 times, most recently from bdbeb73 to 6bd82d5 Compare August 7, 2024 12:14
@xushiwei xushiwei merged commit aa4f518 into goplus:main Aug 7, 2024
5 checks passed
@cpunion cpunion deleted the libuv-async branch September 7, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants