add shader null check #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
505032129
force-pushed
the
change_effect
branch
3 times, most recently
from
e4728c3 to
6cc48e6
Compare
JiepengTan
requested changes
Mar 24, 2025
core/extension/spx_sprite.cpp
Outdated
| { | ||
| return nullptr; | ||
| } | ||
| auto shaderPath = default_material.ptr()->get_shader()->get_path(); |
There was a problem hiding this comment.
Do not return the address of a temporary variable
505032129
force-pushed
the
change_effect
branch
from
6cc48e6 to
9174109
Compare
JiepengTan
approved these changes
Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.