Expose logger statistics #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ting-yuan
reviewed
Nov 24, 2020
| AnalysisResult.success(bindingTrace.bindingContext, module, shouldGenerateCode = false) | ||
| } else { | ||
| AnalysisResult.success(BindingContext.EMPTY, module, shouldGenerateCode = false) | ||
| } |
There was a problem hiding this comment.
Just curious, why not simply changing BindingContext.EMPTY to bindingTrace.bindingContext?
There was a problem hiding this comment.
Because we don't want to fail processing in this branch.
There was a problem hiding this comment.
This kind of explanation isn't really helpful. Please provide more information next time. For example, there are other errors from compiler such as symbol not found that are not fatal to ksp.
ting-yuan
approved these changes
Dec 1, 2020
neetopia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seeing errors or exceptions in logger event, pass the original binding context back to fail compilation.This is quite tricky since there might be errors recorded in processor that are not related to compiler errors. A better solution need to change compiler plugin extension point to support such custom 'fail on sight' styleAnalysisResult. Alternatively it is also doable to just throw exception in KSP to fail compilation but that might be too aggressive.Since error out works now, we no longer need to fail compilation here, however it is still worth to expose logger statistics for future usage.