Add APIs to get JVM names of functions and property accessors #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pass proper module name, add control group for debuggin only
ting-yuan
reviewed
Nov 4, 2020
api/src/main/kotlin/com/google/devtools/ksp/processing/Resolver.kt
Outdated
Show resolved
Hide resolved
| @@ -141,4 +141,33 @@ interface Resolver { | |||
| function: KSFunctionDeclaration, | |||
| containing: KSType | |||
| ): KSFunction | |||
|
|
|||
| /** | |||
| * Returns the jvm name of the given function. | |||
There was a problem hiding this comment.
Can you also mention that this ties to Kotlin compiler's implementation and is not guaranteed to be cross-version compatible? Namely, not guaranteed to work on libraries compiled by other version of compilers.
| // internalInlineReturningFun -> internalInlineReturningFun-HRn7Rpw$mainModule | ||
| // fileLevelInternalFun -> fileLevelInternalFun | ||
| // fileLevelInlineReceivingFun -> fileLevelInlineReceivingFun-E03SJzc | ||
| // fileLevelInlineReturningFun -> fileLevelInlineReturningFun |
There was a problem hiding this comment.
Just curious, why this and fileLevelInternalInlineReturningFun aren't mangled?
There was a problem hiding this comment.
i honestly don't know 🤦
I got these outputs from compiling the same input on a sample project and it is not mangled there.
➜ yigit-google-ksp git:(mangled-names) javap -p ~/src/ManglingPlayground/mainModule/build/classes/kotlin/main/mainPackage/InputKt.class
Compiled from "input.kt"
public final class mainPackage.InputKt {
public static final void fileLevelInternalFun();
public static final void fileLevelInlineReceivingFun-E03SJzc(java.lang.String);
public static final java.lang.String fileLevelInlineReturningFun();
public static final void fileLevelInternalInlineReceivingFun-E03SJzc(java.lang.String);
public static final java.lang.String fileLevelInternalInlineReturningFun();
}
vs it is mangled when it is on a class:
➜ yigit-google-ksp git:(mangled-names) javap -p ~/src/ManglingPlayground/mainModule/build/classes/kotlin/main/mainPackage/Foo.class
Compiled from "input.kt"
public final class mainPackage.Foo {
private java.lang.String normalProp;
private java.lang.String inlineProp;
private java.lang.String internalProp;
private java.lang.String internalInlineProp;
public final java.lang.String getNormalProp();
public final void setNormalProp(java.lang.String);
public final java.lang.String getInlineProp-HRn7Rpw();
public final void setInlineProp-E03SJzc(java.lang.String);
public final java.lang.String getInternalProp$mainModule();
public final void setInternalProp$mainModule(java.lang.String);
public final java.lang.String getInternalInlineProp-HRn7Rpw$mainModule();
public final void setInternalInlineProp-E03SJzc$mainModule(java.lang.String);
public final void normalFun();
public final void inlineReceivingFun-E03SJzc(java.lang.String);
public final java.lang.String inlineReturningFun-HRn7Rpw();
public final void internalInlineReceivingFun-E03SJzc$mainModule(java.lang.String);
public final java.lang.String internalInlineReturningFun-HRn7Rpw$mainModule();
public mainPackage.Foo();
}
|
addressed the review comments and also added a test case with JvmName. Which is also another bonus of this CL as it was something that Room would need to handle manually. |
|
can we squash & merge this one? (I don't have merge access) |
|
added KspExperimental annotation. |
ting-yuan
approved these changes
Nov 13, 2020
neetopia
pushed a commit
that referenced
this pull request
Dec 23, 2020
This API `getJvmName` and `mapToJvmSignature` are also marked as `KspExperimental` and require explicit opt-in. See https://kotlinlang.org/docs/reference/opt-in-requirements.html for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API
getJvmNameto get the jvm name of a method or accessor.This is crucial for annotation processors that generate java source code as they might need to access internal methods in the same module compilation (as it works w/ KAPT).
Fixes #129