Support multi module tests #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes ksp abstract test to support modules. I'm using a directive (MODULE:) that already exists in kotlin codebase but rest of module handling is implemented manually where each sub-module is compiled as is (w/o ksp) and then final module is compiled with KSP. Test: MultiModuleTestProcessor
neetopia
reviewed
Nov 2, 2020
compiler-plugin/src/test/kotlin/com/google/devtools/ksp/test/AbstractKotlinKSPTest.kt
Show resolved
Hide resolved
|
there is a relatively small problem i noticed here where the ResolverImpl do not get the correct module name. |
I've also changed resolver to pass this name to the type mapper. It is a bit hacky because kotlin passes down a special name which we need to revert back to the original
|
added a fix for the module name: |
neetopia
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multi-module tests.
Unfortunately, the current base class we use for tests does not support it. Instead, I've changed base ksp test to directly extend
KotlinBaseTestand added a test file collector that supports modules.Right now, we only run KSP in the last module. It can be changed later if necessary.
This does not have any impact on existing tests as we create a default module if none provided.