add symbol validation API #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ting-yuan
reviewed
Oct 27, 2020
| @@ -78,6 +79,14 @@ fun KSDeclaration.isLocal(): Boolean { | |||
| return this.parentDeclaration != null && this.parentDeclaration !is KSClassDeclaration | |||
| } | |||
|
|
|||
| /** | |||
| * Perform a validation on a given symbol to check if all interested types in symbols enclosed scope are valid. | |||
There was a problem hiding this comment.
Can you define valid? E.g., all immediate type references are resolvable.
| @@ -78,6 +79,14 @@ fun KSDeclaration.isLocal(): Boolean { | |||
| return this.parentDeclaration != null && this.parentDeclaration !is KSClassDeclaration | |||
| } | |||
|
|
|||
| /** | |||
| * Perform a validation on a given symbol to check if all interested types in symbols enclosed scope are valid. | |||
| * @param shouldValidate: A lambda for filtering interested symbols. Default checks all. | |||
There was a problem hiding this comment.
Maybe explain why filtering is needed, i.e., performance.
api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt
Show resolved
Hide resolved
api/src/main/kotlin/com/google/devtools/ksp/visitor/KSValidateVisitor.kt
Show resolved
Hide resolved
| } | ||
|
|
||
| override fun visitPropertyDeclaration(property: KSPropertyDeclaration, data: Unit): Boolean { | ||
| if (property.type.resolve().isError) { |
There was a problem hiding this comment.
Should this be property.type.accept(this, Unit), so that shouldValidate has a chance to skip it?
There was a problem hiding this comment.
The idea here is to skip before jumping into this check, since when checking a property, its type should be valid for the property to be valid.
ting-yuan
reviewed
Oct 31, 2020
| * Perform a validation on a given symbol to check if all interested types in symbols enclosed scope are valid, i.e. resolvable. | ||
| * @param predict: A lambda for filtering interested symbols for performance purpose. Default checks all. | ||
| */ | ||
| fun KSNode.validate(predict: (KSNode, KSNode) -> Boolean = { _, _-> true } ): Boolean { |
ting-yuan
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.