Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ksp returns empty constructor for data classes #279

Closed
yigit opened this issue Jan 30, 2021 · 0 comments · Fixed by #280
Closed

ksp returns empty constructor for data classes #279

yigit opened this issue Jan 30, 2021 · 0 comments · Fixed by #280

Comments

@yigit
Copy link
Collaborator

yigit commented Jan 30, 2021

sample input:

data class Subject(
    var x:Int
)

for some reason, this is returning only 1 constructor and it is synthetic.
this is happening on master, likely because of #275.
I'll try to repro in ksp
yigit added a commit to yigit/ksp that referenced this issue Jan 30, 2021
@yigit
return primary constructor in declarations for KSClassDeclarationImpl
fa7a902 
Unfortunately, it missed primary constructor, causing missing
constructors for that case.

This PR fixes that issue and also extends the test case to
cover it.

Fixes: google#279
yigit added a commit to yigit/ksp that referenced this issue Jan 30, 2021
@yigit
return primary constructor in declarations for KSClassDeclarationImpl
47ae91c 
in terms of how they return declarations (all includes contructor
now).
Unfortunately, it missed primary constructor, causing missing
constructors for that case.

This PR fixes that issue and also extends the test case to
cover it.

Fixes: google#279
yigit added a commit to yigit/ksp that referenced this issue Jan 30, 2021
@yigit
return primary constructor in declarations for KSClassDeclarationImpl
f52d4a6 
PR google#275 made different class declaration backends more consistent
by adding constructor into declarations and making getConstructors
return based on that.
Unfortunately, it missed primary constructor, causing missing
constructors to be returned OR even worse, return an empty constructor
instead of the primary constructor.

This PR fixes that issue and also extends the test case to
cover it.

Fixes: google#279
@yigit yigit mentioned this issue Jan 30, 2021
Merged
neetopia pushed a commit that referenced this issue Feb 1, 2021
@yigit @neetopia
return primary constructor in declarations for KSClassDeclarationImpl
d1493dc 
PR #275 made different class declaration backends more consistent
by adding constructor into declarations and making getConstructors
return based on that.
Unfortunately, it missed primary constructor, causing missing
constructors to be returned OR even worse, return an empty constructor
instead of the primary constructor.

This PR fixes that issue and also extends the test case to
cover it.

Fixes: #279
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

return primary constructor in declarations for KSClassDeclarationImpl yigit/ksp
1 participant
@yigit