Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected descriptor type exception for @Throws annotation #173

Closed
yigit opened this issue Nov 26, 2020 · 1 comment
Closed

Unexpected descriptor type exception for @Throws annotation #173

yigit opened this issue Nov 26, 2020 · 1 comment
Assignees
@neetopia
Labels
bug Something isn't working P1 major features or blocking bugs

Comments

@yigit
Copy link
Collaborator

yigit commented Nov 26, 2020

For the given method:

@Throws(Exception::class)
protected open fun throwsException() {
}

Trying to call:

annotations.forEach {
    it.annotationType.resolve().declaration
}

causes

java.lang.IllegalStateException: Unexpected descriptor type: class org.jetbrains.kotlin.serialization.deserialization.descriptors.DeserializedTypeAliasDescriptor, please file a bug at https://github.com/google/ksp/issues/new

	at com.google.devtools.ksp.processing.impl.ResolverImpl.findDeclaration(ResolverImpl.kt:461)
	at com.google.devtools.ksp.symbol.impl.kotlin.KSTypeImpl$declaration$2.invoke(KSTypeImpl.kt:47)
	at com.google.devtools.ksp.symbol.impl.kotlin.KSTypeImpl$declaration$2.invoke(KSTypeImpl.kt:31)
	at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
	at com.google.devtools.ksp.symbol.impl.kotlin.KSTypeImpl.getDeclaration(KSTypeImpl.kt)
@neetopia neetopia self-assigned this Nov 26, 2020
@neetopia neetopia added bug Something isn't working P1 major features or blocking bugs labels Nov 26, 2020
copybara-service bot pushed a commit to androidx/androidx that referenced this issue Dec 1, 2020
@yigit
Enhance variance inheritance for overrides
2747957 
This CL fixes another case on variance inheritance for overrides where
if there is an overridden method w/ star projected type argument,
we should not use start projection but instead pick covariant (out).

To reproduce it, i've expanded method spec helper test to cover methods
that are not overridden. Unfortunately, it revelaled an issue where
if a kotlin interface overrides another interface with generics, it is
not possible to generate kotlin override for it if the type argument is
a final type. (b/174313780). Only one test case hits it so I've added
a way to ignore them for now (we cannot fix it until room generates
kotlin sources).

I've also hit some KSP bugs:
google/ksp#175
Overrides might fail when overriding with generics. Luckily,
findOverridee method finds it so I've added a workaround by calling
findOverridee. We could possibly only call it instead of calling both
but resolver bug will be eventually fixed in KSP hence I kept that call.

google/ksp#174
Since we call findOverridee for properties now, it might trigger another
issue in KSP. Added a try catch for it now.

google/ksp#173
KSP might throw when resolving deserialized type alias descriptors. Added
a try catch for it where we hit the issue. (reading annotations from an
element that also has @throws annotation).

google/ksp#164
This issue also affects get getJvmName for which we have safeGetJvmName.
In this CL, it happens when finding overridee for getter/setter methods in
java. Added a try catch for it for now.

Bug: 174313780
Bug: 160322705
Test: MethodSpecHelperTest
Change-Id: Ie6347f46027c317ed7784e8d2a0c834012fb4b52
@neetopia
Copy link
Contributor

neetopia commented Dec 4, 2020

Actually this is pretty interesting bug, if you import Throws annotation explicitly with import kotlin.jvm.Throws this won't cause issue.

@neetopia neetopia mentioned this issue Dec 4, 2020
Closed
@neetopia neetopia closed this as completed Dec 5, 2020
copybara-service bot pushed a commit to androidx/androidx that referenced this issue Feb 6, 2021
@yigit
Update KSP to 1.4.30-dev-experimental-20210205
8d0b0d2 
* Removed workarounds in KspTypeElement about detecting constructors
since KSP now has an API to get check if a function is a constructor
* Removed the workaround for google/ksp#175
which seems to be working now. Instead, now we revert some override
calls if its jvm signatures won't match.
* Updated ksp integration test (room kotlin test app) to use the new
kspAndroidTest conffiguration.
* Removed the workaround for google/ksp#173
* Re-enabled @generated annotation for KSP:
  google/ksp#198
* Removed the log for https://github.com/android/kotlin/issues/133
  We'll still use custom logic because calling KSP will invoke the
descriptor APIs and current implementation is working fine.
* Fallback location test now also checks the KSP constructor case
 google/ksp#273

Bug: 160322705
Test: existing tests
Change-Id: I1aef81b0c7475a86d40d38456e765a469ca79de6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neetopia neetopia

Labels
bug Something isn't working P1 major features or blocking bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yigit @neetopia