Declaring kDigits static to avoid a codegen bug in VS2017. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue should be fixed shortly, but until then. https://developercommunity.visualstudio.com/comments/114235/view.html
|
This seemed too noisy for the commit message, but clang generates the same code regardless of static or not. gcc generates different code: with static references a global array, without static, gcc builds up the array from several immediates. I'm not in a position to to judge which is better, but since Parse02d isn't really called on a hotpath, the differences are hopefully irrelevant. |
|
Looks good. Thanks for the fix here and the bug report to Microsoft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue should be fixed shortly, but until then.
https://developercommunity.visualstudio.com/comments/114235/view.html