New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vg: remove {Add,Make}Font #696

Closed

6 tasks done

sbinet opened this issue Jun 1, 2021 · 3 comments · Fixed by #728

Member

sbinet commented Jun 1, 2021 •

edited

Loading

as #693 was proof, keeping vg.AddFont and vg.MakeFont is confusing.

they were kept because x/image/font/sfnt.Font didn't have the ability to give back access to the original []byte (or io.Reader) raw TTF data.

that's no longer the case thanks to https://go-review.googlesource.com/c/image/+/291149

remove AddFont
remove MakeFont
remove FontMap ?
remove vg/fonts (used by vgpdf)
remove use of vg.{Add,Make}Font{,Map} in vg/vgpdf
remove use of vg.{Add,Make}Font{,Map} in vg/vggio

(AFAICT, vg.FontMap is only used in plot/vg/vgpdf to embed fonts. with the x/image CL above being merged, we don't need vg.FontMap there either.)

The text was updated successfully, but these errors were encountered:

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font

e086154

Updates gonum#696.

Member

kortschak commented Jun 1, 2021

SGTM

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font

19dda7f

Updates gonum#696.

sbinet mentioned this issue

vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font #698

Merged

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font

c4b0a1a

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vgpdf: drop use of vg/fonts package

74aecbb

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vggio: drop use of vg/fonts package

3d8b8d2

Use plot/font.Face to translate fonts data to the format Gio is
expecting, without relying on vg.FontMap or vg/fonts.Asset.

Updates gonum#696.

sbinet added a commit that referenced this issue


          vg/vgpdf: remove use of vg.FontMap, retrieve TTF data from sfnt.Font

c96920b

Updates #696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg: remove FontMap, AddFont and MakeFont

92f1930

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vgpdf: drop use of vg/fonts package

2b7fd54

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vggio: drop use of vg/fonts package

021d7b3

Use plot/font.Face to translate fonts data to the format Gio is
expecting, without relying on vg.FontMap or vg/fonts.Asset.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vgpdf: drop use of vg/fonts package

462f486

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vggio: drop use of vg/fonts package

aab80b2

Use plot/font.Face to translate fonts data to the format Gio is
expecting, without relying on vg.FontMap or vg/fonts.Asset.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

ad15ef3

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg: remove FontMap, AddFont and MakeFont

2fe641d

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/vggio: drop use of vg/fonts package

e64c511

Use plot/font.Face to translate fonts data to the format Gio is
expecting, without relying on vg.FontMap or vg/fonts.Asset.

Updates gonum#696.

sbinet mentioned this issue

vg: remove FontMap, AddFont and MakeFont #700

Merged

sbinet added a commit that referenced this issue


          vg: remove FontMap, AddFont and MakeFont

e25766a

Updates #696.

sbinet added a commit that referenced this issue


          vg/vggio: drop use of vg/fonts package

db55d66

Use plot/font.Face to translate fonts data to the format Gio is
expecting, without relying on vg.FontMap or vg/fonts.Asset.

Updates #696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

d085374

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

stippi2 commented Jun 10, 2021

JFYI: I've tried to have a plot rendered to SVG using another default font (plot.DefaultFont = font.Font{Typeface: "Arial"}). This was incredibly painful to get going up to a certain point. Along the way it just crashes, because FontFaces are accessed without checking if they are nil. To work around that, I needed to make font directories known to the vg package, then use vg.MakeFont() to obtain a Face, then register this face with the DefaultFontCache. Only to have it fail regardless, because the SVG renderer has a hard-coded, non-changeable map of type faces to CSS style strings. :-(

Member

kortschak commented Jun 10, 2021

@stippi2 Please file an issue.

stippi2 mentioned this issue

plot: Changing the default font for plots is unintuitive and/or not possible #702

Open

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

4e1c629

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

a712f2f

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

53fba7e

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Updates gonum#696.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

9fca7f4

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes gonum#696.
Fixes gonum#637.

sbinet added a commit to sbinet-gonum/plot that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

a6e7cfd

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes gonum#696.
Fixes gonum#637.

sbinet mentioned this issue

vg/{fonts,vgpdf}: remove vg/fonts package #728

Merged

sbinet closed this as completed in #728

sbinet added a commit that referenced this issue


          vg/{fonts,vgpdf}: remove vg/fonts package

d08bae0

Use embedded characted encoding table for embedded fonts.
This relies on Go >= 1.16 for the "embed" package.

Fixes #696.
Fixes #637.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment