translationKey does not logically connect term pages

[jmooring]

Reference: https://discourse.gohugo.io/t/0-123-8-translationkey-does-not-connect-term-pages/48829

This worked with v0.122.0, but does not work with v0.123.0 and later.

func TestFoo(t *testing.T) {
	t.Parallel()

	files := `
-- hugo.toml --
disableKinds = ['home','rss','section','sitemap','taxonomy']
defaultContentLanguage = 'en'
defaultContentLanguageInSubdir = true
[languages.en]
weight = 1
[languages.pt]
weight = 2
[taxonomies]
category = 'categories'
-- layouts/_default/list.html --
{{ .IsTranslated }}|{{ range .Translations }}{{ .RelPermalink }}|{{ end }}
-- layouts/_default/single.html --
{{ .Title }}|
-- content/p1.en.md --
---
title: p1 (en)
categories: [music]
---
-- content/p1.pt.md --
---
title: p1 (pt)
categories: [música]
---
-- content/categories/music/_index.en.md --
---
title: music
translationKey: foo
---
-- content/categories/música/_index.pt.md --
---
title: música
translationKey: foo
---
`

	b := hugolib.Test(t, files)
	b.AssertFileContent("public/en/categories/music/index.html", "true|/pt/categories/m%C3%BAsica/|")
	b.AssertFileContent("public/pt/categories/música/index.html", "true|/en/categories/music/|")
}

[jmooring]

There are two approaches to term translation:

1. Use the same term across all languages (e.g., "music"), then use different titles within the term branch bundle.
2. As shown in the example above, use language-specific terms and connect them via translationKey as needed.

I think the first is far more common, but I don't have any data to back that up.

[bep]

The translationKey concept was a not so great idea, but I kept it to avoid breakage in the wild (but I obviously missed one spot). I have never seen this in use as in the example above, so this isn't a priority for me to fix.

My current recommendation for all multilingual content in Hugo is to normalise the Path (e.g. to match the main content language). This way the above example would look like:

-- content/categories/music/_index.en.md --
---
title: music
---
-- content/categories/music/_index.pt.md --
---
title: música
---

[bep]

Never mind, I had a quick look at the code and I don't see why it shouldn't work, so it should be an easy fix.

(but i would really recommend putting all the translations into the same folder, re. the above)

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.