Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More progress on sqlite backend #876

Merged
merged 13 commits into from
Feb 10, 2024
Merged

More progress on sqlite backend #876

merged 13 commits into from
Feb 10, 2024

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Feb 9, 2024

No description provided.

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 56 lines in your changes are missing coverage. Please review.

Comparison is base (03f2b89) 63.17% compared to head (5867d8a) 63.15%.

Files Patch % Lines
x/sqlite/db.go 54.76% 32 Missing and 6 partials ⚠️
x/sqlite/json.go 65.95% 10 Missing and 6 partials ⚠️
x/sqlite/sqlite.go 80.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   63.17%   63.15%   -0.03%     
==========================================
  Files         285      287       +2     
  Lines       18720    18856     +136     
==========================================
+ Hits        11826    11908      +82     
- Misses       6357     6398      +41     
- Partials      537      550      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 87963b0 into master Feb 10, 2024
1 of 3 checks passed
@flimzy flimzy deleted the sqlitedb2 branch February 10, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant