Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server config support with basic default implementation #847

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Dec 12, 2023

No description provided.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (e57e528) 77.39% compared to head (dfc4efe) 77.33%.

❗ Current head dfc4efe differs from pull request most recent head c919fc8. Consider uploading reports for the commit c919fc8 to get more accurate results

Files Patch % Lines
x/server/config.go 60.71% 11 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #847      +/-   ##
==========================================
- Coverage   77.39%   77.33%   -0.07%     
==========================================
  Files         200      201       +1     
  Lines       14566    14621      +55     
==========================================
+ Hits        11274    11307      +33     
- Misses       2821     2832      +11     
- Partials      471      482      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flimzy flimzy merged commit 96c3cd7 into master Dec 14, 2023
@flimzy flimzy deleted the serverConfig branch December 14, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant